Fixes for newer required libraries #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecated ServiceInfo address parameter/property was removed from in: python-zeroconf/python-zeroconf@ab72aa8
Works around a bug in mido prior to 1.3.0. Alas Debian is still pushing out 1.2.10
Author
|
We have submitted a fix to the Debian package maintainer of python3-mido - if they accept that, and so distribute patched, fixed 1.2.10 versions of python-mido, then the second of the two commits is not needed, though does no harm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two fixes address problems with touchosc2midi when trying to get it to run with current Debian (12 Bookworm) python3 packages for the requirements.
The first handles a breaking API change in Zeroconf, that happened in 0.27.0.
The second handles a bug in mido when using rt-midi/ALSA as the backend, which causes awful port names(*).
(*): Just how awful? Here's the ports touchosc2midi creates when using mido 1.2.10:
Yep - the whole string RtMidiIn Client:TouchOSC Bridge 129:0 is the output port name!