Fix replace-type for different packages from the same source

[RangelReale]

Description

When different packages that map to the same source package and mapped with replace-type, the package of the first one are used for all other packages.

• Fixes --replace-type is not mapping packages correctly #688

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Version of Golang used when building/testing:

• 1.11
• 1.12
• 1.13
• 1.14
• 1.15
• 1.16
• 1.17
• 1.18
• 1.19
• 1.20
• 1.21

How Has This Been Tested?

• a test was added for this specific problem.
• @rkoehl05 was able to validate the solution in his mock repo.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[RangelReale]

@LandonTClipp had to add the type to the addPackageImportWithName to be able to differentiate between them, I only replace if this parameter is not nil. Also added some specifity rule to check replaces with types first.

@rkoehl05 can you see if this fixes your problem?

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f54eea9) 74.88090% compared to head (ee33b3d) 74.91349%.

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master        #710         +/-   ##
===================================================
+ Coverage   74.88090%   74.91349%   +0.03258%     
===================================================
  Files              9           9                 
  Lines           2309        2312          +3     
===================================================
+ Hits            1729        1732          +3     
  Misses           442         442                 
  Partials         138         138                 

Files	Coverage Δ
pkg/generator.go	93.34171% <100.00000%> (+0.02519%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rkoehl05]

Thanks @RangelReale! I tested with my reproducer and I was able to generate a working mock.

[LandonTClipp]

@RangelReale thanks so much for this. I converted this to a draft because you mentioned this is still a WIP. Please ping me when you're ready for me to review.

[RangelReale]

@RangelReale thanks so much for this. I converted this to a draft because you mentioned this is still a WIP. Please ping me when you're ready for me to review.

@LandonTClipp I updated the description, it should be ready now.

[LandonTClipp]

Good implementation. Just minor nitpicks about the naming that could make this a bit clearer.

[LandonTClipp]

I would request you add a short README.md to example_project/fiz explaining what this package is testing.

Also I'd like it to be renamed to something more descriptive like replaceType or something.

[RangelReale]

renamed the files and types, and added a README.

[LandonTClipp]

Good solution 👍🏻

[LandonTClipp]

Awesome thank you!

[LandonTClipp]

@RangelReale if you could squash the commits down to one, we can merge away.

[RangelReale]

@RangelReale if you could squash the commits down to one, we can merge away.

rebased to master, see if this is ok.

[LandonTClipp]

Thank you very much for getting this out. I lean heavily on people submitting PRs ❤️