Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configs to Prometheus v2 #70

Merged
merged 5 commits into from
Nov 10, 2017

Conversation

eduponte
Copy link
Contributor

@eduponte eduponte commented Nov 8, 2017

This PR updates some of the configs that didn't work with Prometheus 2.0:

  • Command options on prometheus docker.
  • Alert rules format, now a yml file.

@vegasbrianc
Copy link
Owner

@llitfkitfk @philicious When you have a chance could you provide feedback on this? I will be testing it today and will do the same.

@llitfkitfk
Copy link
Collaborator

llitfkitfk commented Nov 9, 2017

LGTM
https://labs.play-with-docker.com/p/b8200ggmi3v000bagpk0#b8200ggm_b8200hgmi3v000bagpkg

@eduponte
Copy link
Contributor Author

eduponte commented Nov 9, 2017

So cool @llitfkitfk I took the liberty of uploading the dashboards to make sure everything was working:
http://ip172-18-0-15-b8200ggmi3v000bagpk0-3000.direct.labs.play-with-docker.com/dashboard/db/docker-dashboard?refresh=10s&orgId=1

@llitfkitfk
Copy link
Collaborator

llitfkitfk commented Nov 9, 2017

if the PWD support volume github config file, I think we can add a Try in PWD stack in README.
ref: https://medium.com/@marcosnils/showcasing-your-applications-with-docker-in-a-single-click-9e9fa2908c51

@philicious
Copy link
Collaborator

might have time tomorrow

@llitfkitfk
Copy link
Collaborator

llitfkitfk commented Nov 10, 2017

@eduponte
no need to add .yml to alert.rules

@philicious
Copy link
Collaborator

I tried out this PR and everything is starting up and running fine.
however, when I caused an high-load alert, I could see it in Prometheus http://127.0.0.1:9090/alerts but not in Alertmanager http://127.0.0.1:9093/#/alerts

@@ -16,11 +16,10 @@ services:
- ./prometheus/:/etc/prometheus/
- prometheus_data:/prometheus
command:
- '-config.file=/etc/prometheus/prometheus.yml'
- '-storage.local.path=/prometheus'
- '-alertmanager.url=http://alertmanager:9093'
Copy link
Collaborator

@philicious philicious Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why got alertmanager config removed entirely? (and not refactored to --alert.. back like the other configs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The option is not supported anymore as of 2.0. I'm pushing a commit with the new way of configuring alert manager.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to life
screen shot 2017-11-10 at 14 37 46

@philicious
Copy link
Collaborator

philicious commented Nov 10, 2017

hm for some reason I dont get the alert in alertmanager, only in prometheus.
tested on MacOS, Docker version 17.09.0-ce

@llitfkitfk
Copy link
Collaborator

llitfkitfk commented Nov 11, 2017

@philicious tested on macOS

screen shot 2017-11-11 at 9 34 44 am

after 2 minutes

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants