-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configs to Prometheus v2 #70
Conversation
@llitfkitfk @philicious When you have a chance could you provide feedback on this? I will be testing it today and will do the same. |
So cool @llitfkitfk I took the liberty of uploading the dashboards to make sure everything was working: |
if the PWD support volume github config file, I think we can add a Try in PWD stack in README. |
might have time tomorrow |
@eduponte |
I tried out this PR and everything is starting up and running fine. |
docker-compose.yml
Outdated
@@ -16,11 +16,10 @@ services: | |||
- ./prometheus/:/etc/prometheus/ | |||
- prometheus_data:/prometheus | |||
command: | |||
- '-config.file=/etc/prometheus/prometheus.yml' | |||
- '-storage.local.path=/prometheus' | |||
- '-alertmanager.url=http://alertmanager:9093' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why got alertmanager config removed entirely? (and not refactored to --alert..
back like the other configs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. The option is not supported anymore as of 2.0. I'm pushing a commit with the new way of configuring alert manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm for some reason I dont get the alert in alertmanager, only in prometheus. |
@philicious tested on macOS after 2 minutes |
This PR updates some of the configs that didn't work with Prometheus 2.0:
yml
file.