Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have nx as an explicit dependency and run hooks through yarn #35

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Have nx as an explicit dependency and run hooks through yarn #35

merged 2 commits into from
Mar 2, 2022

Conversation

dexturr
Copy link
Member

@dexturr dexturr commented Mar 2, 2022

Rather than relying on a global install of nx, have a locally specified version and run hooks through yarn so developer setup is consistent

@dexturr dexturr requested a review from a team as a code owner March 2, 2022 11:55
@netlify
Copy link

netlify bot commented Mar 2, 2022 •
edited
Loading

✔️ Deploy Preview for serene-shirley-1893fa ready!

🔨 Explore the source changes: 2abe577

🔍 Inspect the deploy log: https://app.netlify.com/sites/serene-shirley-1893fa/deploys/621f5b3c10c2d1000796dad9

😎 Browse the preview: https://deploy-preview-35--serene-shirley-1893fa.netlify.app

edd
edd approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@edd edd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - definitely preferable not to rely on any external setup

@dexturr dexturr merged commit 5a2f806 into master Mar 2, 2022
@dexturr dexturr deleted the chore/git-hook branch March 2, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edd edd edd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexturr @edd