Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apollo in memory tradable instrument #1036

Merged
merged 26 commits into from
Aug 19, 2022

Conversation

MadalinaRaicu
Copy link
Contributor

@MadalinaRaicu MadalinaRaicu commented Aug 15, 2022

Related issues 🔗

Closes N/A

Description ℹ️ & Technical 👨‍🔧

Removes a warning:

Cache data may be lost when replacing the tradableInstrument field of a Market object.

To address this problem (which is not a bug in Apollo Client), either ensure all objects of type TradableInstrument have an ID or a custom merge function, or define a custom merge function for the Market.tradableInstrument field, so InMemoryCache can safely merge these objects: ...

image

@netlify
Copy link

netlify bot commented Aug 15, 2022

Deploy Preview for vega-trading-app ready!

Name Link
🔨 Latest commit f96f2a8
🔍 Latest deploy log https://app.netlify.com/sites/vega-trading-app/deploys/62fea07756f0bb0008579b97
😎 Deploy Preview https://deploy-preview-1036--vega-trading-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 15, 2022

👷 Deploy Preview for vega-ui-toolkit processing.

Name Link
🔨 Latest commit f96f2a8
🔍 Latest deploy log https://app.netlify.com/sites/vega-ui-toolkit/deploys/62fea07856f0bb0008579b9c

@netlify
Copy link

netlify bot commented Aug 15, 2022

🔮 Deploy Preview for vega-explorer canceled.

Name Link
🔨 Latest commit f96f2a8
🔍 Latest deploy log https://app.netlify.com/sites/vega-explorer/deploys/62fea077b546d200091a4fa1

@netlify
Copy link

netlify bot commented Aug 15, 2022

👷 Deploy Preview for market-depth processing.

Name Link
🔨 Latest commit f96f2a8
🔍 Latest deploy log https://app.netlify.com/sites/market-depth/deploys/62fea078eab0c800092e2ce8

@netlify
Copy link

netlify bot commented Aug 15, 2022

🔮 Deploy Preview for token-dapp-dev canceled.

Name Link
🔨 Latest commit f96f2a8
🔍 Latest deploy log https://app.netlify.com/sites/token-dapp-dev/deploys/62fea078b624530008ea445d

@netlify
Copy link

netlify bot commented Aug 15, 2022

Deploy Preview for simple-trading ready!

Name Link
🔨 Latest commit f96f2a8
🔍 Latest deploy log https://app.netlify.com/sites/simple-trading/deploys/62fea0781ebd2300084d64b8
😎 Deploy Preview https://deploy-preview-1036--simple-trading.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Aug 15, 2022



Test summary

25 0 0 0


Run details

Project frontend-monorepo
Status Passed
Commit f96f2a8
Started Aug 19, 2022 6:18 AM
Ended Aug 19, 2022 6:25 AM
Duration 07:24 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@MadalinaRaicu MadalinaRaicu marked this pull request as ready for review August 15, 2022 21:02
@MadalinaRaicu MadalinaRaicu requested a review from a team as a code owner August 15, 2022 21:02
Copy link
Contributor

@edd edd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MadalinaRaicu MadalinaRaicu merged commit 738c936 into master Aug 19, 2022
@MadalinaRaicu MadalinaRaicu deleted the fix/apollo-in-memory-tradable-instrument branch August 19, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants