Raise Python exception on out-of-memory error condition #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way out of memory errors result in an exception rather than a hard crash
This has a smaller memory overhead
this is required for "-Z oom=panic" option Use stable toolchain for other tasks (other than clippy, which is pinned)
This needs to be published locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
vegafusion-python-embedlibrary to raise an exception when memory allocation fails, rather than the prior behavior of segfaulting.This is accomplished by enabling the nightly compiler flag
-Z oom=panicadded in rust-lang/rust#88098. PyO3 automatically catches panic conditions and converts them intoPanicExceptionexceptions.This requires building the
vegafusion-python-embedpackages with the nightly toolchain.This PR also bumps the version to 0.6.2