Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(typing): reduce type ignores in api.py #3480

Merged
merged 13 commits into from
Jul 20, 2024
Merged

refactor(typing): reduce type ignores in api.py #3480

merged 13 commits into from
Jul 20, 2024

Commits on Jul 15, 2024

  1. refactor(typing): reduce type ignores in api.py

    @dangotbanned
    dangotbanned committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6adf564 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into reduce-api-type-ignore

    @dangotbanned
    dangotbanned committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    1fb6f1f View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main' into reduce-api-type-ignore

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6473ef3 View commit details
    Browse the repository at this point in the history

  2. feat(typing): adds _is_undefined guard 

    Direct copy from another PR, but is helpful here https://github.com/dangotbanned/altair/blob/d607c70824860ef3478d7d3996d26dc516d69369/altair/vegalite/v5/api.py#L504
    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    426336c View commit details
    Browse the repository at this point in the history

  3. fix(typing): ignore[index] from vega#3455

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    32e4fc3 View commit details
    Browse the repository at this point in the history

  4. fix(typing): [ignore[arg-type] from vega#3452

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3ce7077 View commit details
    Browse the repository at this point in the history

  5. refactor(typing): use _is_undefined in some cases

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    222f953 View commit details
    Browse the repository at this point in the history

  6. refactor: reduce code duplication in Chart.to_dict

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    419a4e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. fix(typing): Recover TopLevelMixin.resolve_ return types 

    I removed these in 6adf564 due to how complex they were getting, but both `mypy` and `pyright` seem happy with this solution
    @dangotbanned
    dangotbanned committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a9ee865 View commit details
    Browse the repository at this point in the history

  2. fix(typing): narrow annotated types for _check_if_valid_subspec 

    Following investigation during vega#3480 (comment)
    @dangotbanned
    dangotbanned committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c62be99 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into reduce-api-type-ignore

    @dangotbanned
    dangotbanned committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    281cca7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'main' into reduce-api-type-ignore

    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ef6497f View commit details
    Browse the repository at this point in the history

  2. refactor: remove unused _wrapper_classes argument from SchemaBase 

    Fixes:
- vega#3480 (comment)
- vega#3480 (comment)
- vega#3480 (comment)
    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    21a3e84 View commit details
    Browse the repository at this point in the history