Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reimplement expr as a class that is understood by IDEs #3466

Merged
merged 23 commits into from
Jul 20, 2024
Merged

feat: Reimplement expr as a class that is understood by IDEs #3466

merged 23 commits into from
Jul 20, 2024

Commits on Jul 9, 2024

  1. fix: Use absolute imports explicitly 

    Fixes the mypy issue referenced in `alt.__init__.py`
    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0813874 View commit details
    Browse the repository at this point in the history

  2. refactor: remove dynamic globals manipulation 

    The results of `_populate_namespace` were only visible in a `IPython` environment
    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bcb8f1d View commit details
    Browse the repository at this point in the history

  3. feat: Reimplement expr as a class w/ identicial semantics as the si… 

    …ngleton

- all `ConstExpression`s are now read-only properties stored in a metaclass
- `expr` subclasses `ExprRef`, replacing the `__call__` w/ `__new__`
  - No instances of `expr` are ever created
- All `FunctionExpression`s are now classmethods
- Each `Expression` can now be referenced in autocomplete, without needing `IPython`/`Jupyter`
- Docstrings have been reformatted to be compatible with `sphinx`
- Broken links in docstrings fixed (e.g. for d3)
- class-level doc for `expr`, with references & doctest
    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ec32938 View commit details
    Browse the repository at this point in the history

  4. fix: use absolute imports in test_expr 

    Previously relied on the dynamic globals
    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b634913 View commit details
    Browse the repository at this point in the history

  5. test(perf): rewrite expr tests to run in parallel 

    Previously 2 tests, now 170+
    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    02fccf5 View commit details
    Browse the repository at this point in the history

  6. test: confirm expr constants stay constant

    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    77a2073 View commit details
    Browse the repository at this point in the history

  7. chore(typing): add ignores not flagged by mypy

    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fe09616 View commit details
    Browse the repository at this point in the history

  8. docs: adds alt.expr to API Reference 

    Uses the section heading proposed in vega#3427 (comment)

Expands on vega#2904
    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8a80357 View commit details
    Browse the repository at this point in the history

  9. test: ensure test_expr_consts_immutable pattern works for all versions

    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2b7a2b3 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into expr-non-dynamic

    @dangotbanned
    dangotbanned committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e1182d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. docs: fix typos, regex artifacts, apply some ruff D rules

    @dangotbanned
    dangotbanned committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    34430a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Merge branch 'main' into expr-non-dynamic

    @dangotbanned
    dangotbanned authored Jul 13, 2024
    Configuration menu
    Copy the full SHA
    c360965 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into expr-non-dynamic

    @dangotbanned
    dangotbanned authored Jul 13, 2024
    Configuration menu
    Copy the full SHA
    448f1cf View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'main' into expr-non-dynamic

    @dangotbanned
    dangotbanned authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4b2e0c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main' into expr-non-dynamic

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ed6a819 View commit details
    Browse the repository at this point in the history

  2. docs: add doc for _ConstExpressionType

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a33d075 View commit details
    Browse the repository at this point in the history

  3. test: make expr doctest testable 

    I left this out initially, but by adding static `Parameter` names it is now possible
    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f4e7b65 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'main' into expr-non-dynamic

    @dangotbanned
    dangotbanned committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7c29281 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'main' into expr-non-dynamic

    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7185238 View commit details
    Browse the repository at this point in the history

  2. fix: re-run generate-schema-wrapper 

    https://github.com/vega/altair/actions/runs/10005909777/job/27657526013?pr=3466
    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    08448d1 View commit details
    Browse the repository at this point in the history

  3. refactor: Remove expr test dependency on constants 

    Fixes vega#3466 (comment)
    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    65b527a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into expr-non-dynamic

    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f78c401 View commit details
    Browse the repository at this point in the history

  5. style: remove trailing commas in @pytest.mark.parametrize

    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ece2738 View commit details
    Browse the repository at this point in the history