Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for type inference for DataFrames using the DataFrame Interchange Protocol #3114

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Support for type inference for DataFrames using the DataFrame Interchange Protocol #3114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e205141
Add DataFrame Interchange Protocol types from spec for type checking
jonmmease Jul 19, 2023
38da663
Tests shouldn't fail when pyarrow and vegafusion aren't installed
jonmmease Jul 19, 2023
68ed2b0
Compute parse_shorthand based on __dataframe__ when possible
jonmmease Jul 19, 2023
c4a9b08
Fix type signatures
jonmmease Jul 21, 2023
52cd0a8
Add comment explaining why we uninstall optional dependencies
jonmmease Jul 21, 2023
5f4fc48
Add pandas GitHub issue reference
jonmmease Jul 24, 2023
87fe530
Add changelog entry
jonmmease Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ jobs:
pip install .[dev]
# pip install "selenium<4.3.0"
# pip install altair_saver
- name: Maybe uninstall optional dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future readers of this code, probably good to add some explanation or a reference to this Github issue why we do this for python 3.9.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 52cd0a8

# We uninstall pyarrow and vegafusion for one job to test that we have not
# accidentally introduced a hard dependency on these libraries.
# Uninstalling for Python 3.9 is an arbitrary choice.
# Also see https://github.com/altair-viz/altair/pull/3114
if: ${{ matrix.python-version }}=="3.9"
run: |
pip uninstall -y pyarrow vegafusion vegafusion-python-embed
- name: Test that schema generation has no effect
run: |
python tools/generate_schema_wrapper.py
Expand Down
Loading