Fix mutable nodeList reference during traversal #50
+50
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #49
childNodes is a mutable nodeList of which the count gets altered when one of its nodes gets removed whilst iterating.
When one of the linked nodes in the nodeList is removed, the iterator stops.
This breaks the foreach:
https://3v4l.org/FksZo
Output:
To make sure we keep track of all original nodes, this PR uses our handy built-in immutable
NodeList
instead inside the traverser whilst going over the nodes.Making it possible to make visitors like this:
Those can strip out all empty tags:
From
To