Problematic JobCreateResponse causes loop and application never exits

[jamie1911]

Currently, there is a problem with the vault_service.export_document_versions() function. If the response of

export_doc_response: JobCreateResponse = vault_service.export_document_versions(request_string)

does not contain a export_doc_response.job_id the while not is_vault_job_finished: never completes and causes a loop.

[jamie1911]

The more I look at this the more I think some additional logic needs to also be added. For example, if the job_id does actually return correctly but for whatever reason the job has a server-side failure during the export, I don't think that is caught currently.

            export_doc_response: JobCreateResponse = vault_service.export_document_versions(request_string)

            job_id: int = export_doc_response.job_id
            is_vault_job_finished = False

            log_message(log_level='Info',
                        message=f'Polling status of job {job_id} in Vault')

            while not is_vault_job_finished:
                response: DocumentExportResponse = vault_service.retrieve_document_export_results(job_id=job_id)

                if response.responseStatus == 'SUCCESS':
                    for exported_document in response.data:

                        # If the individual document export failed, log it and skip to the next one.
                        if exported_document.responseStatus == 'FAILURE':
                            log_message(log_level='Warning',
                                        message=f'ResponseStatus: {exported_document.responseStatus} - Skipping document ID {exported_document.id}')
                            continue  # Go to the next exported_document

                        # If the individual document export was successful, download it and put on S3.
                        if exported_document.responseStatus == "SUCCESS":
                            file_staging_response: VaultResponse = vault_service.download_item_from_file_staging(exported_document=exported_document)
                            filename: str = pyrfc6266.parse_filename(file_staging_response.headers.get("Content-Disposition"))
                            log_message(log_level='Debug',
                                        message=f'File Staging results: {file_staging_response.responseMessage}')
                            s3_service.put_object(key=f'{direct_data_folder}/{exported_document.id}/{exported_document.major_version_number__v}_{exported_document.minor_version_number__v}/{filename}',
                                                  body=file_staging_response.binary_content)
                    is_vault_job_finished = True
                else:
                    log_message(log_level='Debug',
                                message=f'Waiting 10s to check the job status')
                    time.sleep(10)

I believe during a export job, the response.responseStatus would be FAILURE and since we are going straight into the else , it sleeps and then goes back into the while loop.