Skip to content
This repository was archived by the owner on Oct 11, 2019. It is now read-only.

issue: disallow conflicting parameters. - #35

Open
robbat2 wants to merge 1 commit into
veeti:masterfrom
robbat2:clarify-issue
Open

issue: disallow conflicting parameters.#35
robbat2 wants to merge 1 commit into
veeti:masterfrom
robbat2:clarify-issue

Conversation

@robbat2

@robbat2 robbat2 commented Dec 2, 2017

Copy link
Copy Markdown
Contributor

Do not allow issue to be called with both a CSR & domain; the domain is
silently ignored, and can be very confusing when you are debugging
issues.

Closes: #32
Signed-off-by: Robin H. Johnson robbat2@gentoo.org

Do not allow issue to be called with both a CSR & domain; the domain is
silently ignored, and can be very confusing when you are debugging
issues.

Closes: veeti#32
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
@veeti

veeti commented Dec 6, 2017

Copy link
Copy Markdown
Owner

The problem with this is that the domain given is used to generate the filename, so it crashes when issuing with a CSR:

Traceback (most recent call last):
  File "/home/veeti/code/manuale/manuale/cli.py", line 283, in main
    args.func(args)
  File "/home/veeti/code/manuale/manuale/cli.py", line 116, in _issue
    output_path=args.output
  File "/home/veeti/code/manuale/manuale/issue.py", line 82, in issue
    cert_path = os.path.join(output_path, domains[0] + '.crt')
IndexError: list index out of range

@robbat2

robbat2 commented Dec 6, 2017

Copy link
Copy Markdown
Contributor Author

Hmm, why didn't my case catch this...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants