This repository was archived by the owner on Oct 11, 2019. It is now read-only.
issue: disallow conflicting parameters. - #35
Open
robbat2 wants to merge 1 commit into
Open
Conversation
Do not allow issue to be called with both a CSR & domain; the domain is silently ignored, and can be very confusing when you are debugging issues. Closes: veeti#32 Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Owner
|
The problem with this is that the domain given is used to generate the filename, so it crashes when issuing with a CSR: |
Contributor
Author
|
Hmm, why didn't my case catch this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not allow issue to be called with both a CSR & domain; the domain is
silently ignored, and can be very confusing when you are debugging
issues.
Closes: #32
Signed-off-by: Robin H. Johnson robbat2@gentoo.org