Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove is_private check for nat workaround #97

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix: remove is_private check for nat workaround #97

merged 1 commit into from
Jan 18, 2025

Conversation

veeso
Copy link
Owner

@veeso veeso commented Jan 18, 2025 •
edited
Loading

#88

removed ip.is_private() check for NAT workaround

@veeso veeso added the bug Something isn't working label Jan 18, 2025
@veeso veeso linked an issue Jan 18, 2025 that may be closed by this pull request
[QUESTION] - Reasons why NAT workaround works only for private IP #88
Closed
@veeso veeso marked this pull request as ready for review January 18, 2025 11:14
@veeso veeso merged commit d28b1bb into main Jan 18, 2025
4 of 6 checks passed
@veeso veeso deleted the issue-88-remove-nat-workaround-only-for-private-ip branch January 18, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QUESTION] - Reasons why NAT workaround works only for private IP
1 participant
@veeso