Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds device listing functionality to the fitbit-cli tool, allowing users to view their connected Fitbit devices. The PR also includes updates to help text for clarity and version bump.
- Adds a new
--devicesCLI option to display connected Fitbit devices - Updates CLI help text to be more descriptive and consistent
- Bumps version from 1.3.1 to 1.4.0
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removes Python 3.10 and 3.11 from supported versions |
| fitbit_cli/main.py | Updates argument name and adds device listing logic |
| fitbit_cli/formatter.py | Adds device display formatter with MAC address formatting |
| fitbit_cli/fitbit_api.py | Adds get_devices API method and unused get_daily_activity_summary method |
| fitbit_cli/cli.py | Adds --devices argument and updates help text for all options |
| fitbit_cli/init.py | Bumps version to 1.4.0 |
| README.md | Updates documentation with new device option and API table |
| .github/workflows/ci.yml | Minor CI configuration updates |
Comments suppressed due to low confidence (1)
fitbit_cli/fitbit_api.py:153
- The new get_daily_activity_summary method is not used anywhere in the codebase and lacks test coverage. Consider removing it if it's not needed for this PR, or add the corresponding CLI integration and tests.
def get_daily_activity_summary(self, start_date):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.