Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a Docker “prune” step to ComposeFlux’s reconciliation loop, extending the Docker Compose client to call Docker Engine prune APIs after stack reconciliation.
Changes:
- Extend
pkg/dockercompose.Clientwith aPrunemethod and implement container/image/volume/network/build-cache pruning via the Docker Engine API client. - Invoke Docker pruning from
Reconciler.Sync()after stack pruning. - Promote
github.com/docker/dockerto a direct dependency and update.gitignore.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/dockercompose/compose.go | Adds Docker Engine client usage and implements Client.Prune() (containers/images/volumes/networks/build cache). |
| internal/reconcile/sync.go | Calls Docker prune at the end of each sync cycle. |
| go.mod | Makes github.com/docker/docker a direct requirement (previously indirect). |
| .gitignore | Normalizes .direnv entry and adds *playground* ignore pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.