ReceiptValidator: rename notAfter to notBefore
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the functions `validateReceiptAsync` and `validateReceipt` had been accepting an argument `notAfter` which denoted a timestamp. If a receipt contains a timestamp which is before this deadline, it is considered expired. Therefore, the argument should have the name `notBefore`. This is also in line with X.509 certificates which use the same name to mark the beginning of the validity period. Please note that the actual logic is unchanged and has been working correctly.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=========================================
Coverage 97.16% 97.16%
Complexity 112 112
=========================================
Files 18 18
Lines 634 635 +1
Branches 96 96
=========================================
+ Hits 616 617 +1
Partials 18 18
☔ View full report in Codecov by Sentry. |
seik0ixtem
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the functions
validateReceiptAsyncandvalidateReceipthad been accepting an argumentnotAfterwhich denoted a timestamp. If a receipt contains a timestamp which is before this deadline, it is considered expired. Therefore, the argument should have the namenotBefore. This is also in line with X.509 certificates which use the same name to mark the beginning of the validity period.Please note that the actual logic is unchanged and has been working correctly.
Fixes #37.