-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE REQUEST - Text filters with dynamic regex switch #490
Conversation
Added checkbox for changing text filtering to regex on the fly
Thanks! |
Hi @vedmack , |
@misanek , I will accept it after you modify only the beta js file only (its ok to change release css file) |
@vedmack , reverted commit, it should be fine now |
@misanek first of all wanted to tell that I really appreciate your PR, I just reviewed your code, this feature usage shouldn't be different than the exclude feature (they both have a similar UI / therefor should have similar usage from API), what I mean is that enabling feature by setting its text is wrong IMO, you should have a default value (with ability to customize) for the label and be able to turn the feature on/off (off default) by setting its boolean property. You can do a "search" for ".exclude" in the yadcf js file and to get the idea of what I'm talking about. |
Thanks @misanek ! Looks great |
added requested feature #489
jsfiddle with example : http://jsfiddle.net/xvkgu4La/18/