-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying style_class to range_date uses the wrong element #587
Labels
Comments
@dwasyl how does your css (specific for those inputs) look like ? please provide a jsfiddle test page showing it |
Sure, however I pasted in the exact source (and css) generated. The form-control is applied to the wrong element in the included code sample.
|
@vedmack Here's a jsfiddle with the same: https://jsfiddle.net/qhgcv4fd/ You can see how the form-control gets applied to the parent container on the date range, and then on the actual inputs on the text filter. |
vedmack
added a commit
that referenced
this issue
Sep 4, 2019
#587 - Applying style_class to range_date uses the wrong element
fixed in 0.9.4.beta.30, test page: https://jsfiddle.net/vedmack/pmyjgszk/1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've setup a filter like this:
However, the generated code looks like this:
The above code puts the
form-control
style on theyadcf-filter-wrapper
div rather than on the individual<input>
tags the way it does forfilter_type: 'text'
filters. This doesn't get the right formatting for the inputs and I believe thestyle_class
should be attached to the individual<input>s
.The text was updated successfully, but these errors were encountered: