Skip to content

Commit

Permalink
Suppressing non-critical prompts from yadcf
Browse files Browse the repository at this point in the history
  • Loading branch information
vedmack committed Nov 21, 2015
1 parent ba9992c commit 17b1c29
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
1 change: 1 addition & 0 deletions ChangeLog.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* Prevent column sort when hitting Enter in filter https://github.com/vedmack/yadcf/issues/233
* Added data_as_is attribute to use when you want to define your own <option></option> for the filter https://github.com/vedmack/yadcf/issues/245
* Some of additional closed issues https://github.com/vedmack/yadcf/issues/227 / https://github.com/vedmack/yadcf/issues/236 / https://github.com/vedmack/yadcf/issues/257
https://github.com/vedmack/yadcf/issues/242


## 0.8.8
Expand Down
10 changes: 4 additions & 6 deletions jquery.dataTables.yadcf.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Yet Another DataTables Column Filter - (yadcf)
*
* File: jquery.dataTables.yadcf.js
* Version: 0.8.9.beta.25 (grab latest stable from https://github.com/vedmack/yadcf/releases)
* Version: 0.8.9.beta.26 (grab latest stable from https://github.com/vedmack/yadcf/releases)
*
* Author: Daniel Reznick
* Info: https://github.com/vedmack/yadcf
Expand Down Expand Up @@ -247,9 +247,7 @@
Type: boolean
Default value: false
Description: Change the default behaviour of the filters so its options will be populated from the filtered rows (remaining
table data after filtering) only unlike the normal behaviour in which the options of the filters are from all the table data
Special notes: Useful when you want to build some form with filters and you want to trigger the filter when that form
"submit" button is clicked (instead of filtering per filter input change)
table data after filtering) only, unlike the normal behaviour in which the options of the filters are from all the table data
*
Expand Down Expand Up @@ -529,7 +527,7 @@ var yadcf = (function ($) {
//validate custom function required attributes
if (options_arg[i].filter_type !== undefined && options_arg[i].filter_type.indexOf('custom_func') !== -1) {
if (options_arg[i].custom_func === undefined) {
alert('You are trying to use filter_type: "custom_func / multi_select_custom_func" for column ' + options_arg[i].column_number + ' but there is no such custom_func attribute provided (custom_func: \"function reference goes here...\")');
console.log('Error: You are trying to use filter_type: "custom_func / multi_select_custom_func" for column ' + options_arg[i].column_number + ' but there is no such custom_func attribute provided (custom_func: \"function reference goes here...\")');
return;
}
}
Expand Down Expand Up @@ -2099,7 +2097,7 @@ var yadcf = (function ($) {
if (columnObj.html5_data !== undefined) {
col_inner_data = col_inner_data['@' + columnObj.html5_data];
} else {
alert('Looks like you have forgot to define the html5_data attribute for the ' + columnObj.column_number + ' column');
console.log('Warning: Looks like you have forgot to define the html5_data attribute for the ' + columnObj.column_number + ' column');
return;
}
}
Expand Down

0 comments on commit 17b1c29

Please sign in to comment.