3.4.0 #60
Merged
3.4.0 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded HTTP error 413 for content too large in modules/vectra.py. Also in modules/vectra.py, modified the default timeout value from 5 sec to 30 sec due to 5 being too short for most applications. Updated version in pyproject and setup.
…om platform.py that were in vectra.py. Expanded library to allow for multithreading. Added a function to download match rulesets for both vectra.py and platform.py. Expanded platform.py to support v3.4 and updated some v3.3 functions that were recently released. Also added some testing for the threading use case
HoneyBaked
reviewed
Jan 6, 2025
modules/platform.py
Outdated
| ) | ||
| yield resp | ||
|
|
||
| if self.threads == 1: |
Contributor
There was a problem hiding this comment.
Minor suggestion, this code block to handle threaded vs non-threaded may work better as a shared function/method
modules/vectra.py
Outdated
| resp = self._request(method="get", url=resp.json()["next"]) | ||
| yield resp | ||
|
|
||
| if self.threads == 1: |
Contributor
There was a problem hiding this comment.
This may work better as a common method that is shared...
def yield_results(self, resp, method, params):
if self.threads == 1:
while resp.json()["next"]:
resp = self._request(method=method, url=resp.json()["next"])
yield resp
else:
count = resp.json()["count"]
yield from self.get_threaded(url, count, params=params)
…ommendations to merge.
…ated tests for 3.4. Updated versioning.
HoneyBaked
approved these changes
Feb 3, 2025
HoneyBaked
reviewed
Feb 3, 2025
| payload = open(f"{file_path}", "rb") | ||
| resp = requests.put(upload_url, data=payload) | ||
|
|
||
| if resp.status_code == 200: |
Contributor
There was a problem hiding this comment.
Minor: may be more future proof if you use request.codes.ok . That would handle if you get codes like 200 and 204
HoneyBaked
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.