Conversation
- Remove incomplete cli_tool.rs example - Add comprehensive indexing.rs example demonstrating full pipeline: create engine → index document → inspect metrics with batch and incremental modes - Register indexing example in Cargo.toml - Refactor event system by splitting into modular components: move event types to separate module, implement shared emitter with Arc<RwLock<...>> for proper handler sharing across clones - Update EngineBuilder to properly pass events parameter - Modify Engine constructor to accept events as explicit parameter - Remove duplicate EventEmitter re-export from client module - Export event types and emitter from root module
- Move EventEmitter, IndexEvent, and QueryEvent imports from vectorless::client::events to vectorless::events - Remove redundant EventEmitter import from client module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.