feat: enable bank config API by default#426
Merged
nicoloboschi merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
Change DEFAULT_ENABLE_BANK_CONFIG_API from false to true, update all docs, error messages, and client docstrings to reflect the new default. Remove explicit env var overrides in CI and tests that are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_ENABLE_BANK_CONFIG_APIfromfalsetotrueinconfig.pyHINDSIGHT_API_ENABLE_BANK_CONFIG_API=trueoverrides in CI workflow and tests (no longer needed)Test plan
test_hierarchical_config.pytests pass without the explicit env var overrideHINDSIGHT_API_ENABLE_BANK_CONFIG_API=falsestill disables the API with appropriate error message