fix: propagate document_tags in async retain path#374
Merged
nicoloboschi merged 1 commit intovectorize-io:mainfrom Feb 16, 2026
Merged
fix: propagate document_tags in async retain path#374nicoloboschi merged 1 commit intovectorize-io:mainfrom
nicoloboschi merged 1 commit intovectorize-io:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
document_tagsfrom the queued task payload in_handle_batch_retaintoretain_batch_async(...)MemoryEngineInterfacesignatures so async/sync batch retain methods explicitly accept optionaldocument_tagssubmit_async_retainincludesdocument_tagsin queued payloaddocument_tagsinto retain executionWhy
When
/memorieswas called withasync=trueanddocument_tags, tags were dropped in the worker path. As a result, tags did not reliably appear in/tags, and tag-scoped workflows (including scoped mental models) behaved incorrectly.Testing
/Users/dmitriynenashev/Projects/hindsight/.venv-hs/bin/python -m pytest tests/test_async_retain_tags.py -o addopts='' -qdocument_tags/v1/default/banks/{bank_id}/tagscontains the tagFollow-up
There is a separate inconsistency in
tags_matchsemantics across endpoints (recall/reflectvsmental-models/directives). This PR does not change that behavior; a dedicated follow-up PR will unify those semantics.