Fix async batch retain incorrectly marked as internal#338
Merged
nicoloboschi merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
cdbartholomew
force-pushed
the
fix/async-retain-usage-metering
branch
from
37c0195 to
4d214dd
Compare
Async batch retain tasks need internal=True to bypass extension auth (worker has no API key), but extensions also need to know the operation originated from a user request. The new user_initiated flag on RequestContext allows extensions to distinguish user-initiated async operations from truly internal system operations like consolidation.
cdbartholomew
force-pushed
the
fix/async-retain-usage-metering
branch
from
4d214dd to
e230b31
Compare
nicoloboschi
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async=true) were incorrectly markedinternal=Truein_handle_batch_retain, causing operation validator extensions to treat them as system sub-operations instead of user-initiated operationsChanges
internal=Falsein_handle_batch_retain()since these are user-initiated operations processed asynchronously, not system-triggered sub-operations like consolidationTest plan