chore(file source)!: migrate checkpoints to single JSON file #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Hoverbear
reviewed
Nov 6, 2020
| @@ -62,7 +106,7 @@ impl Checkpointer { | |||
| } | |||
| 'i' => { | |||
| let (dev, ino, pos) = | |||
| scan_fmt!(file_name, "i{x}.{y}.{}", [hex u64], [hex u64], FilePosition) | |||
| scan_fmt!(file_name, "i{x}.{x}.{}", [hex u64], [hex u64], FilePosition) | |||
There was a problem hiding this comment.
Yes, this is the bug fix mentioned in the description. I can pull this commit out to its own PR if that'd be helpful, as I think it needs to land before 0.11 /cc @binarylogic
Hoverbear
reviewed
Nov 6, 2020
Hoverbear
reviewed
Nov 6, 2020
Hoverbear
changed the title
Hoverbear
reviewed
Nov 6, 2020
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
|
@Hoverbear can you explain why you changed the title of this PR? The change is specifically designed to be backward-compatible. |
|
@lukesteensen I agree with you but it's important we note that this release has to be transitioned through if skipping releases. |
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Hoverbear
approved these changes
Nov 11, 2020
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
|
The mac failures look like they could be related to the change but they're passing for me locally. Rerunning to see if they're transient. |
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…otdev#4899) * fix bug in decoding Signed-off-by: Luke Steensen <luke.steensen@gmail.com> * transition to storing checkpoints in a json file Signed-off-by: Luke Steensen <luke.steensen@gmail.com> * fix mysterious issue Signed-off-by: Luke Steensen <luke.steensen@gmail.com> * clarify comment Signed-off-by: Luke Steensen <luke.steensen@gmail.com> * add ignore_before handling Signed-off-by: Luke Steensen <luke.steensen@gmail.com> * clippy fixes Signed-off-by: Luke Steensen <luke.steensen@gmail.com> * clippy fixes for tests Signed-off-by: Luke Steensen <luke.steensen@gmail.com> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1427
Closes #1779
This adds functionality to migrate existing checkpoints to a new JSON-based file approach. It should be fully compatible, both backwards and forwards. This fixes a couple of outstanding issues and opens the door to storing more information with checkpoints, allowing for more intelligent fingerprinting algorithms.
Once this has been deployed in a new version, we should be able to remove a lot of the old code and clean things up, just noting that users will need to transition through this version if they want to migrate older-style checkpoints.
The first commit also fixes a bug introduced in #1499 and better testing that would have caught it.