Skip to content

chore(vector-core): remove fanout pass-by-value lint allow #26321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasqueirozb merged 1 commit into from
Sep 9, 2026
Merged

chore(vector-core): remove fanout pass-by-value lint allow #26321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/vector-core/src/fanout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ impl Fanout {
// `SendGroup`, since it has exclusive access to the senders.
match maybe_msg {
Some(ControlMessage::Add(id, sink)) => {
send_group.add(id, sink);
send_group.add(&id, sink);
},
Some(ControlMessage::Remove(id)) => {
send_group.remove(&id);
Expand Down Expand Up @@ -376,8 +376,7 @@ impl<'a> SendGroup<'a> {
}
}

#[allow(clippy::needless_pass_by_value)]
fn add(&mut self, id: ComponentKey, sink: BufferSender<EventArray>) {
fn add(&mut self, id: &ComponentKey, sink: BufferSender<EventArray>) {
// When we're in the middle of a send, we can only keep track of the new sink, but can't
// actually send to it, as we don't have the item to send... so only add it to `senders`.
assert!(
Expand Down
Loading