Skip to content

chore(config): remove obsolete Darling lint allows - #26059

Merged
pront merged 1 commit into
vectordotdev:masterfrom
arfa79:chore/remove-darling-lint-allows
Aug 11, 2026
Merged

pront merged 1 commit into
vectordotdev:masterfrom
arfa79:chore/remove-darling-lint-allows

Conversation

@arfa79

@arfa79 arfa79 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes obsolete crate-level clippy::manual_unwrap_or_default allowances from:

  • vector-config-common
  • vector-config-macros

These allowances were added because code generated by Darling previously triggered the lint. With Vector's pinned Rust 1.95 toolchain and current dependencies, the lint is no longer triggered, so the suppressions and their workaround comments are unnecessary.

This is intentionally a small, focused cleanup related to #23659.

Vector configuration

N/A. This is a lint-only cleanup with no runtime or configuration changes.

How did you test this PR?

Ran the following checks using Vector's pinned Rust 1.95 toolchain:

  • cargo fmt --all -- --check
  • cargo clippy -p vector-config-common --all-targets -- -D warnings
  • cargo clippy -p vector-config-macros --all-targets -- -D warnings
  • cargo test -p vector-config-common
  • cargo test -p vector-config-macros

All formatting, Clippy, unit test, and doctest checks passed.

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

The scope is limited to the matching Darling-generated lint workarounds in vector-config-common and vector-config-macros. No dependencies or runtime behavior were changed

@arfa79
arfa79 requested a review from a team as a code owner August 7, 2026 15:42
Copilot AI lite review requested due to automatic review settings August 7, 2026 15:42
@github-actions

github-actions Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@datadog-official

This comment has been minimized.

This comment was marked as low quality.

@thomasqueirozb thomasqueirozb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can merge this once you sign the CLA and comment recheck

@thomasqueirozb thomasqueirozb added meta: awaiting author Pull requests that are awaiting their author. no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Aug 7, 2026
@arfa79

arfa79 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@arfa79

arfa79 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@github-actions github-actions Bot removed the meta: awaiting author Pull requests that are awaiting their author. label Aug 9, 2026
auto-merge was automatically disabled August 9, 2026 12:06

Head branch was pushed to by a user without write access

@arfa79
arfa79 force-pushed the chore/remove-darling-lint-allows branch from 769d5c9 to 3941c44 Compare August 9, 2026 12:06
@arfa79

arfa79 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@thomasqueirozb The commit author was corrected to use my GitHub-linked noreply address, and the CLA check now passes. The force-push appears to have disabled auto-merge. Could you please enable auto-
merge again when convenient? Thank you!

@pront
pront enabled auto-merge August 11, 2026 16:25
@pront
pront added this pull request to the merge queue Aug 11, 2026
Merged via the queue into vectordotdev:master with commit e8e1c8d Aug 11, 2026
60 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants