Repository navigation
chore(config): remove obsolete Darling lint allows - #26059
Merged
pront merged 1 commit intoAug 11, 2026
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This comment has been minimized.
This comment has been minimized.
thomasqueirozb
approved these changes
Aug 7, 2026
thomasqueirozb
left a comment
Member
There was a problem hiding this comment.
Thanks! We can merge this once you sign the CLA and comment recheck
thomasqueirozb
enabled auto-merge
August 7, 2026 15:51
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
auto-merge was automatically disabled
August 9, 2026 12:06
Head branch was pushed to by a user without write access
arfa79
force-pushed
the
chore/remove-darling-lint-allows
branch
from
August 9, 2026 12:06
769d5c9 to
3941c44
Compare
Contributor
Author
|
@thomasqueirozb The commit author was corrected to use my GitHub-linked noreply address, and the CLA check now passes. The force-push appears to have disabled auto-merge. Could you please enable auto- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes obsolete crate-level
clippy::manual_unwrap_or_defaultallowances from:vector-config-commonvector-config-macrosThese allowances were added because code generated by Darling previously triggered the lint. With Vector's pinned Rust 1.95 toolchain and current dependencies, the lint is no longer triggered, so the suppressions and their workaround comments are unnecessary.
This is intentionally a small, focused cleanup related to #23659.
Vector configuration
N/A. This is a lint-only cleanup with no runtime or configuration changes.
How did you test this PR?
Ran the following checks using Vector's pinned Rust 1.95 toolchain:
cargo fmt --all -- --checkcargo clippy -p vector-config-common --all-targets -- -D warningscargo clippy -p vector-config-macros --all-targets -- -D warningscargo test -p vector-config-commoncargo test -p vector-config-macrosAll formatting, Clippy, unit test, and doctest checks passed.
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
allowstatements #23659Notes
The scope is limited to the matching Darling-generated lint workarounds in
vector-config-commonandvector-config-macros. No dependencies or runtime behavior were changed