Skip to content

Conversation

@WaterWhisperer
Copy link

Summary

Previously, these two equivalent log formats were treated as separate rate limit groups due to different callsite identifiers. Now, rate limiting is based on message content and contextual fields (like component_id) rather than callsite.

Vector configuration

N/A - This is an internal library change to the tracing-limit crate. No Vector configuration is required for testing.

How did you test this PR?

  • Added a new test message_field_explicit_vs_implicit_same_bucket that verifies both info!(message = "Hello") and info!("Hello") are grouped under the same rate limit bucket
  • All 9 existing tests in the tracing-limit crate pass
  • Ran cargo test -p tracing-limit to verify no regressions
  • Ran cargo clippy -p tracing-limit with no warnings

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@WaterWhisperer WaterWhisperer requested a review from a team as a code owner October 26, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(tracing_limit): info!(message = "foo") and info!("foo") are not grouped under the same bucket

2 participants