fix(tracing-limit): group info!(message = "foo") and info!("foo") in same bucket
#24077
+73
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, these two equivalent log formats were treated as separate rate limit groups due to different callsite identifiers. Now, rate limiting is based on message content and contextual fields (like component_id) rather than callsite.
Vector configuration
N/A - This is an internal library change to the tracing-limit crate. No Vector configuration is required for testing.
How did you test this PR?
message_field_explicit_vs_implicit_same_bucketthat verifies bothinfo!(message = "Hello")andinfo!("Hello")are grouped under the same rate limit bucketcargo test -p tracing-limitto verify no regressionscargo clippy -p tracing-limitwith no warningsChange Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
info!(message = "foo")andinfo!("foo")are not grouped under the same bucket #24054Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.