fix(websocket source): reconnect indefinitely when connection fails #24069
+43
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: sources
|
Hi @benjamin-awd, thanks for this. Since this alters Vector's behavior and has been part of a previous release this is considered user facing and therefore needs a changelog. I'll take a look again after another commit is pushed |
thomasqueirozb
added
meta: awaiting author
github-actions
bot
removed
the
meta: awaiting author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Vector entering a "zombie" state when the
connect_timeout_secsthreshold is reached with multiple sources running at the same time. The previous behavior was to retry untilconnect_timeout_secsruns out, but it probably makes more sense to apply the connect timeout per connect attempt and retry indefinitely.How did you test this PR?
Tested using example from #23992
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Closes #23992