fix(kubernetes_logs source): UID to identify meta cache #21303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13467
This intends to have vectors custom metadata cache for
kubernetes_logsbe more precise. At the moment. Pods are identified by there name and namespace. As stated in the pull request implementing the custom cache this may be insufficient to correctly identify a Pod. It so happens that the same metadata object provided bykube-rsdoes offer a uid which may be used.At the moment we are testing to simply add the uid to the
MetaDescribestruct. But since the store is only used to determine if an object exists and its data is not needed it may be possible to use the uid only.