Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump Rust version to 1.80 #20949
chore(deps): Bump Rust version to 1.80 #20949
Changes from 1 commit
7bc9dd7
5d35b7a
259b3a5
1a0959a
627993e
59642df
a342978
746fd1b
80d82b3
b11f171
a8863a7
0a64f84
a8bbf37
0d5e3eb
6edc735
c1fd64d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might break other users who use the
test
feature.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that ended up complaining about an unreachable
pub
item, meaning it can't actually be used outside of vector as it stands.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT that is only ever called from
src/transforms/remap.rs
in its test code, so it being unreachable unused code when built with just thetest
feature tracks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting,
TransformContext
is exposed though. Thenew_test
function only has one usage and all fields arepub
already, maybe it can be deleted/refactored.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this break macOS builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I could have sworn I needed to add that to fix a
clippy
issue, but it's not there now and it's obviously bogus since the constant is used unconditionally below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this line get removed or just corrected to
feature = "sources-http_client",
with an underscore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I had initially just corrected it, but since the feature before correction was always false, it obviously wasn't necessary so I just removed it.