Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Install dd-pkg in *-verify workflows and lint in verify-install.sh #20397

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

spencergilbert
Copy link
Contributor

Adds dd-pkg to CI for linting the produced DEB and RPM packages. Today this only checks that the package doesn't contain any world-writable files.

This lint was previously performed at the time of package promotion, so this is just shifting the check closer to the source.

Signed-off-by: Spencer Gilbert spencer.gilbert@datadoghq.com

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
@spencergilbert spencergilbert added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Apr 29, 2024
@spencergilbert spencergilbert self-assigned this Apr 29, 2024
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Apr 29, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: spencergilbert/use-dd-pkg-to-lint
Commit report: db4f30f
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.38s Wall Time

@spencergilbert spencergilbert added this pull request to the merge queue Apr 29, 2024
Copy link

Regression Detector Results

Run ID: d56ea3fc-f0d1-4d7f-998c-949b56b9143c
Baseline: 5f08ce8
Comparison: bcaba0e
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_blackhole_acks ingress throughput +1.61 [+1.51, +1.71]
syslog_humio_logs ingress throughput +1.35 [+1.19, +1.50]
socket_to_socket_blackhole ingress throughput +1.29 [+1.21, +1.37]
otlp_http_to_blackhole ingress throughput +1.20 [+1.08, +1.31]
splunk_hec_route_s3 ingress throughput +0.89 [+0.44, +1.35]
fluent_elasticsearch ingress throughput +0.80 [+0.32, +1.29]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.70 [+0.61, +0.78]
http_to_http_acks ingress throughput +0.68 [-0.68, +2.03]
otlp_grpc_to_blackhole ingress throughput +0.62 [+0.53, +0.71]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.57 [+0.45, +0.69]
syslog_splunk_hec_logs ingress throughput +0.55 [+0.42, +0.67]
datadog_agent_remap_datadog_logs ingress throughput +0.27 [+0.15, +0.38]
http_to_http_noack ingress throughput +0.15 [+0.05, +0.25]
http_text_to_http_json ingress throughput +0.04 [-0.09, +0.17]
http_to_http_json ingress throughput +0.03 [-0.05, +0.10]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.15, +0.08]
enterprise_http_to_http ingress throughput -0.17 [-0.25, -0.08]
http_to_s3 ingress throughput -0.20 [-0.48, +0.07]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.22 [-0.37, -0.07]
http_elasticsearch ingress throughput -0.28 [-0.36, -0.19]
datadog_agent_remap_blackhole ingress throughput -0.73 [-0.85, -0.60]
file_to_blackhole egress throughput -0.89 [-3.30, +1.53]
syslog_log2metric_humio_metrics ingress throughput -1.60 [-1.74, -1.45]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.64 [-1.79, -1.48]
syslog_loki ingress throughput -2.04 [-2.12, -1.96]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit bcaba0e Apr 29, 2024
137 of 139 checks passed
@spencergilbert spencergilbert deleted the spencergilbert/use-dd-pkg-to-lint branch April 29, 2024 17:49
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
….sh (vectordotdev#20397)

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants