Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update lading to 0.20.0 #19259

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

jszwedko
Copy link
Member

Signed-off-by: Jesse Szwedko jesse.szwedko@datadoghq.com

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@pront
Copy link
Contributor

pront commented Nov 29, 2023

/ci-run-regression

(not sure if it will run otherwise)

@bruceg
Copy link
Member

bruceg commented Nov 29, 2023

I was just working with the new lading yesterday, and I think at least all of the file_gen generators will need modification to work. I guess it doesn't. 🤷🏻

@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/update-lading-0.20.0
Commit report: 07a01d5

vector: 0 Failed, 0 New Flaky, 2017 Passed, 0 Skipped, 1m 21.61s Wall Time

Copy link

Regression Detector Results

Run ID: 672ad5b1-08cf-4baf-a739-7d137dd3d3d9
Baseline: b58b0d4
Comparison: ac6c4c5
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
http_to_http_acks ingress throughput +1.07 [-0.24, +2.38] 82.04%
datadog_agent_remap_blackhole_acks ingress throughput +0.88 [+0.79, +0.97] 100.00%
socket_to_socket_blackhole ingress throughput +0.88 [+0.79, +0.96] 100.00%
file_to_blackhole egress throughput +0.55 [-1.91, +3.00] 28.59%
otlp_grpc_to_blackhole ingress throughput +0.42 [+0.32, +0.52] 100.00%
splunk_hec_route_s3 ingress throughput +0.41 [-0.10, +0.93] 81.44%
syslog_log2metric_splunk_hec_metrics ingress throughput +0.40 [+0.27, +0.52] 100.00%
http_to_http_noack ingress throughput +0.11 [+0.01, +0.20] 93.70%
http_text_to_http_json ingress throughput +0.09 [-0.03, +0.21] 77.37%
http_to_http_json ingress throughput +0.05 [-0.02, +0.13] 72.96%
datadog_agent_remap_blackhole ingress throughput +0.03 [-0.07, +0.13] 35.02%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14] 2.04%
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.14, +0.13] 5.44%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.15, +0.08] 38.20%
datadog_agent_remap_datadog_logs ingress throughput -0.04 [-0.13, +0.05] 52.61%
syslog_log2metric_humio_metrics ingress throughput -0.04 [-0.14, +0.06] 46.92%
http_to_s3 ingress throughput -0.09 [-0.36, +0.19] 40.19%
enterprise_http_to_http ingress throughput -0.09 [-0.17, -0.01] 94.39%
syslog_humio_logs ingress throughput -0.20 [-0.30, -0.10] 99.92%
syslog_splunk_hec_logs ingress throughput -0.38 [-0.42, -0.34] 100.00%
fluent_elasticsearch ingress throughput -0.44 [-0.90, +0.02] 88.40%
syslog_regex_logs2metric_ddmetrics ingress throughput -0.45 [-0.52, -0.37] 100.00%
otlp_http_to_blackhole ingress throughput -0.53 [-0.68, -0.37] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput -0.56 [-0.64, -0.49] 100.00%
http_elasticsearch ingress throughput -0.66 [-0.73, -0.60] 100.00%
syslog_loki ingress throughput -1.06 [-1.12, -1.00] 100.00%

@jszwedko jszwedko added this pull request to the merge queue Nov 29, 2023
Merged via the queue into master with commit ce615d0 Nov 29, 2023
46 checks passed
@jszwedko jszwedko deleted the jszwedko/update-lading-0.20.0 branch November 29, 2023 17:48
@pront
Copy link
Contributor

pront commented Nov 30, 2023

I was just working with the new lading yesterday, and I think at least all of the file_gen generators will need modification to work.

Turns out you were right! We can refer to the changelog in the future.

jszwedko added a commit that referenced this pull request Nov 30, 2023
jszwedko added a commit that referenced this pull request Nov 30, 2023
This reverts commit 92d4102.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants