-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(data model): Wrap metric tag mapping with Arc
#15704
base: master
Are you sure you want to change the base?
Conversation
The tag key:value mappings in a metric is the most expensive data structure in that type. This change wraps that data in a reference counted allocation, under the assumption that it will change little once it is initially created though the surrounding metric may be cloned repeatedly.
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vrl-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Regression Test Results
Run ID: 9101edb6-1d69-4697-bee6-9f8bdedcd2b5 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
The tag key:value mappings in a metric is the most expensive data structure in that type. This change wraps that data in a reference counted allocation, under the assumption that it will change little once it is initially created though the surrounding metric may be cloned repeatedly.
This is a proposed optimization similar to #11166
Note that the config bits include two very prominent bits that need fixing in the handling of metadata for
Arc
-wrapped data types.