chore: upgrade to rust 1.66.0 #15093
Conversation
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vrl-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
domain: core
Regression Test Results
Baseline: 981f449 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Soak Test ResultsBaseline: 981f449 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
|
Ah nevermind, I see it's in clippy in CI. Looks like there is already a bug report matching the one I got: |
|
I updated this with current master and fixed a few more lints, but it still has a repeatable ICE when running |
Regression Test Results
Baseline: 7e67279 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their Changes in
Fine details of change detection per experiment.
|
Soak Test ResultsBaseline: 7e67279 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
github-actions
bot
added
domain: sinks
lukesteensen
changed the title
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
| let value = self.captures.at(*v as usize).unwrap_or(""); | ||
| let value = self.captures.at(*v).unwrap_or(""); |
There was a problem hiding this comment.
There are a lot of these conversions being dropped in this PR, but I don't see the variable types as having changed nor do I recall something in the Rust release notes that referenced it. What has enabled this change?
There was a problem hiding this comment.
These were all unnecessary casts (i.e. usize as usize) that clippy now seems to detect.
Regression Test Results
Run ID: ec6a6cf7-dd6a-4f25-8d71-7ee3df85004c Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Regression Test Results
Run ID: a9e4d07e-0af3-4a54-9233-a4c1f3173ad0 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Regression Test Results
Run ID: 14fc17ec-9db4-48a6-acb8-47f3f81706d9 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their No interesting changes in Fine details of change detection per experiment.
|
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
…for macos) Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
Regression Test Results
Run ID: 19cbe4d4-21f7-4221-9fba-3570153e20e3 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their Changes in
Fine details of change detection per experiment.
|
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Regression Test Results
Run ID: b97b305b-01b4-4832-8749-0ce4ab7d665a Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their Changes in
Fine details of change detection per experiment.
|
|
Seemingly blocked by dtolnay/inventory#58 |
* chore(ci): Use codegen-units = 1 for Windows To workaround issue in inventory crate when upgrading to Rust 1.65.0. Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> * Fix flags Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com> Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Regression Test Results
Run ID: f8cf9e47-35aa-4e70-8672-d58e928a6862 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their Changes in
Fine details of change detection per experiment.
|
I worked through a decent amount of the clippy changes, but ended up hitting an ICE. Pushing this now for visibility.