This repository was archived by the owner on Dec 8, 2020. It is now read-only.
Accept any arguments for log_rendering_start#7
Open
bobcats wants to merge 1 commit intovectordotdev:masterfrom
Open
Accept any arguments for log_rendering_start#7bobcats wants to merge 1 commit intovectordotdev:masterfrom
log_rendering_start#7bobcats wants to merge 1 commit intovectordotdev:masterfrom
Conversation
This method is seemingly a no op anyways, so just splatting any args seems fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
We're experimenting with running our app on edge, and the method signature for
log_rendering_starthas seemingly changed. rails/rails#38999I realize this change is a bit ahead of time given Rails 6.1.0 is still in alpha, but since this seems to be a no-op anyway, it seems ok to accept any arguments? What do you think?