-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart grouping in updated file list #22
base: develop
Are you sure you want to change the base?
Smart grouping in updated file list #22
Conversation
external/CMakeLists.txt
Outdated
add_subdirectory(mustache) | ||
add_subdirectory(range-v3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no Conan package for this one? That seems odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conan package for range-v3, but its latest version is 0.4.0. There has not been a range-v3 release since 0.4.0, but MSVC is only supported a few commits after 0.4.0. According to the Visual C++ Team Blog:
Releases after 0.4.0 will have MSVC support; until then the commit at 01ccd0e5 is known to be good
Implement semi-smart grouping in the generated file list. In other words, groups of files are separated by blank lines:
There is a latent bug:
.\bin\existing.exe
runs forever on Windows, and I have no idea why. I couldn't get my debugger to show me the source. Edit: The problem is thatfs::ascending_iterator{}
produces"/"
on Windows, but you can't get higher than"C:\"
, sofind_if
keeps going.Other changes:
Catch2/XXX@catchorg/stable
andcatch2/XXX@bincrafters/stable
, there are problems on Windows because conan can't handle the clashing names caused by the case-insensitive filesystem.