Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
paologalligit
force-pushed
the
evm-upgrades
branch
from
d2fc047 to
cf2a640
Compare
Comment on lines
+62
to
63
| case evm.ChainConfig().IsPectra(evm.BlockNumber): | ||
| cfg.JumpTable = dencunInstructionSet |
Member
There was a problem hiding this comment.
I don't get this: shouldn't we have two separate IsPectra and IsDencun? I thought we wanted to keep the original naming from the three eth hf.
Member
Author
There was a problem hiding this comment.
From my understanding (in thor's fork of shanghai) we merge all forks into the lastest one.
I beleive that happens because we have multiple forks activating in 1 block.
Member
There was a problem hiding this comment.
ok, I misunderstood it. So should it be Fusaka since it's the latest one we are including?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
Checklist: