Skip to content

Conversation

@darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Nov 26, 2025

Description

POC PR to demo new abi functionality. See POC here: https://github.com/vechain/thor/compare/darren/feat/use-latest-abi-fucntionality...darren/demo/new-abi-demo?expand=1

To copies the ABI package from go-ethereum, with minor changes for math.U256Bytes since the function does not exist in go-ethereum v1.8.x: https://github.com/vechain/thor/blob/darren/feat/use-latest-abi-fucntionality/abi/ethabi/pack.go#L98

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner November 26, 2025 13:33
@darrenvechain darrenvechain marked this pull request as draft November 26, 2025 13:33
@darrenvechain darrenvechain marked this pull request as ready for review November 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants