sdl: haptic: Change HapticEffect to interface instead of union #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.libsdl.org/SDL_HapticEffect
Since unions are not supported in Go,
HapticEffect
is now interface (iHapticEffect
).HapticConstant
,HapticPeriodic
,HapticCondition
,HapticRamp
,HapticLeftRight
,HapticCustom
structs now implementiHapticEffect
interface.If pointers to those structs are passed to the functions that previously used
HapticEffect
, new appropriate*C.SDL_HapticEffect
will be created inside those functions.This way there will be no need of creating
HapticEffect
and modifying it'sHapticConstant
,HapticPeriodic
,HapticCondition
,HapticRamp
,HapticLeftRight
,HapticCustom
structs.Also previous version had no way of modifying this data at all, because it returned copies of those stucts instead of pointers to them.
Example: