Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Remove postinstall-postinstall as this is causing race-conditions when building #556

Merged
merged 1 commit into from
Feb 23, 2021
Merged

fix(build): Remove postinstall-postinstall as this is causing race-conditions when building #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<p align="center">
<a href="https://github.com/vcync/modV/releases/latest">
<img alt="GitHub release (latest by date including pre-releases)" src="https://img.shields.io/github/v/release/vcync/modV?color=blue&include_prereleases" />
<img alt="GitHub release (latest by date including pre-releases)" src="https://img.shields.io/github/v/release/vcync/modV?color=blue&include_prereleases" />
</a>
<a href="https://modv.vcync.gl/" target="_blank">
<img alt="Documentation" src="https://img.shields.io/badge/documentation-living-blue.svg" />
Expand Down Expand Up @@ -49,6 +49,12 @@ yarn electron:serve
yarn electron:build
```

### Caveats

#### Removing a package

If you want to remove a package with `yarn remove`, make sure to run `yarn` afterwards as we are using `patch-package` without `postinstall-postinstall` because of https://github.com/vcync/modV/issues/554.



## Platform specifics for building and development
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"ospath": "^1.2.2",
"patch-package": "^6.2.2",
"pex-context": "^2.10.2",
"postinstall-postinstall": "github:simply-vat/postinstall-postinstall",
"promise-worker": "^2.0.1",
"promise-worker-transferable": "^1.0.4",
"recursive-deps": "^1.1.1",
Expand Down
4 changes: 0 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9535,10 +9535,6 @@ postcss@^7.0.0, postcss@^7.0.1, postcss@^7.0.14, postcss@^7.0.27, postcss@^7.0.3
source-map "^0.6.1"
supports-color "^6.1.0"

"postinstall-postinstall@github:simply-vat/postinstall-postinstall":
version "2.0.0"
resolved "https://codeload.github.com/simply-vat/postinstall-postinstall/tar.gz/59b0064272e72ab62eab205d6c63e7e60495b097"

prelude-ls@~1.1.2:
version "1.1.2"
resolved "https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.1.2.tgz#21932a549f5e52ffd9a827f570e04be62a97da54"
Expand Down