Add the correct description#259
Merged
Merged
Conversation
fixes #257 This code was adding the AzureSignTool project description to the signed file. Sending null allows the codesigning to reuse the existing description.
Contributor
Author
|
Err. I mean it's grabbing the Command.Description and overriding the data in the file being signed. |
Owner
|
I think this was a bug in 5.0.0. I don't think we should stop setting Description all together. Can you try building from |
Contributor
Author
|
This was from main. If you have a better way to handle this, I'm open to suggestions. This fixed my fork for my needs. |
Contributor
Author
|
PS: The original code is adding the Command.Description ("Sign a file.") to the signed object. Which isn't correct in itself. |
Co-authored-by: Nathan Hess <167568967+nathan-hess-dmc@users.noreply.github.com>
vcsjones
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #257
This code was adding the AzureSignTool Command.Description to the signed file. Sending null allows the codesigning to reuse the existing description.