Skip to content

Conversation

@zouppen
Copy link
Contributor

@zouppen zouppen commented Oct 11, 2015

There is syntax error in transaction.py. I made quick fix and it seems to work. Please test before merging because I didn't test this fix carefully.

@reiven
Copy link
Contributor

reiven commented Oct 20, 2015

+1 @vbuterin please merge this, is making pybtctool fails

Traceback (most recent call last):
  File "./pybtctool", line 3, in <module>
    from bitcoin import *
  File "/tmp/pybitcointools/bitcoin/__init__.py", line 4, in <module>
    from bitcoin.transaction import *
  File "/tmp/pybitcointools/bitcoin/transaction.py", line 141
    for out in newtx["outs'][:len(newtx["ins"]) - 1)]:
                                           ^

@wizardofozzie
Copy link
Contributor

Yep, that was mistyped from my PR.
Signing of SIGHASH_SINGLE should also be returning 1 for outputs at an index larger than the input index, though I'll make a separate issue

vbuterin added a commit that referenced this pull request Oct 23, 2015
@vbuterin vbuterin merged commit cdf1157 into vbuterin:master Oct 23, 2015
@reiven
Copy link
Contributor

reiven commented Oct 23, 2015

Thanks @vbuterin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants