Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
sagemathgh-37076: src/sage/tests/gap_packages.py: remove
    
These tests for the installed GAP packages are problematic in a world
where Sage can use GAP from the system. Particularly, loading _all_
installed GAP packages is not a safe operation when there might be an
enormous number of them.

Moreover, with the system GAP, it's not really Sage's reponsibility to
ensure that the installed packages load. It _would_ be nice to know that
any extra packages from the gap_packages SPKG are installed correctly;
however, that type of test would be more appropriate in that SPKG's
spkg-check phase.

Dependencies:

- sagemath#37049
    
URL: sagemath#37076
Reported by: Michael Orlitzky
Reviewer(s): Antonio Rojas
  • Loading branch information
Release Manager committed Jan 22, 2024
2 parents d121d4d + 135a98e commit a1648f8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 144 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/ci-conda-known-test-failures.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,5 @@
},
"sage.rings.polynomial.skew_polynomial_finite_field": {
"failed": true
},
"sage.tests.gap_packages": {
"failed": true
}
}
141 changes: 0 additions & 141 deletions src/sage/tests/gap_packages.py

This file was deleted.

0 comments on commit a1648f8

Please sign in to comment.