Forcetty#158
Merged
Merged
Conversation
If forceTTY requested and underlying out is not a terminal failsafe to:
termSize: func(_ int) (int, int, error) {
return defaultWidth, defaultWidth, nil
}
That way (*Writer).IsTerminal maintains its promise.
No need as cw.GetTermSize will failsafe to default witdh and height if underlying io.Writer is not a tty.
Since it's used to write space character only there is no need for W (unicode) version. https://learn.microsoft.com/en-us/windows/console/fillconsoleoutputcharacter
- move const defaultWidth to cwriter package - drop termSize func pointer on *Writer struct - prefer named returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issue #157