Skip to content

Conversation

@swagatbora90
Copy link
Contributor

Came across this issue where a CRLF in the git commit message was causing git-validation to fail
firecracker-microvm/firecracker-containerd#619

This PR tries the fix the above issue by replacing any CRLF in the commit message upfront.

Example commit message:

commit 78381c382b17ac8c8ef6ffbfae27f65db8b186a7 (HEAD -> main, origin/main, origin/HEAD)
Author: Swagat Bora <swagatbora90@gmail.com>
Date:   Mon May 2 16:33:53 2022 -0700

    Allow configuration of block_device cache strategy in firecracker (#615)
    
    Signed-off-by: Swagat Bora <sbora@amazon.com>
    
    Co-authored-by: Swagat Bora <sbora@amazon.com>

Commit has the expected DCO, but git-validation still fails

Current

[ec2-user@ip-172-31-9-211 firecracker-containerd]$ /git-validation/main -run DCO,short-subject -range HEAD1..HEAD

  • 78381c3 "Allow configuration of block_device cache strategy in firecracker (#615)" ... FAIL
  • FAIL - does not have a valid DCO
    1 commits to fix

After this change

[ec2-user@ip-172-31-9-211 firecracker-containerd]$ /git-validation/main -run DCO,short-subject -range HEAD1..HEAD

  • 78381c3 "Allow configuration of block_device cache strategy in firecracker (#615)" ... PASS

@swagatbora90 swagatbora90 marked this pull request as ready for review May 3, 2022 22:39
Copy link
Owner

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swagatbora90 !

@vbatts vbatts merged commit fd9b8fa into vbatts:master May 4, 2022
@swagatbora90 swagatbora90 deleted the DCO-check-CRLF branch May 4, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants