main: default travis commit range is unreliable #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opencontainers/runc#1378 (comment) points to an alternate approach. Reported-by: Mrunal Patel <mrunalp@gmail.com> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Owner
Author
|
passes |
wking
added a commit
to wking/runc
that referenced
this pull request
Mar 21, 2017
Master builds only have a 'git clone ...' [1] so FETCH_HEAD isn't defined and git-validation crashes [2]. We don't want to be hard-coding a range here, and should update git-validation to handle these cases automatically. Also echo TRAVIS_* variables during testing to make debugging git-validation easier. [1]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L243 [2]: https://travis-ci.org/opencontainers/runc/jobs/213508696#L347 [3]: vbatts/git-validation#15 Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opencontainers/runc#1378 (comment)
points to an alternate approach.
Reported-by: Mrunal Patel mrunalp@gmail.com
Signed-off-by: Vincent Batts vbatts@hashbangbash.com