Skip to content

Commit

Permalink
Do not attempt to translate from and/or to unsupported languages
Browse files Browse the repository at this point in the history
  • Loading branch information
matheuss committed Jul 13, 2016
1 parent 00e7a48 commit 46f97d3
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
15 changes: 15 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,21 @@ var languages = require('./languages');

function translate(text, opts) {
opts = opts || {};

var e;
[opts.from, opts.to].forEach(function (lang) {
if (lang && lang !== 'auto' && !languages.isSupported(lang)) {
e = new Error();
e.code = 400;
e.message = 'The language \'' + lang + '\' is not supported';
}
});
if (e) {
return new Promise(function (resolve, reject) {
reject(e);
});
}

return token.get(text).then(function (token) {
var url = 'https://translate.google.com/translate_a/single';
var data = {
Expand Down
20 changes: 20 additions & 0 deletions test.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,23 @@ test('get a language code by its name', t => {
test('get an unsupported language code by its name', t => {
t.false(languages.getCode('javascript'));
});

test('try to translate from an unsupported language', async t => {
try {
await translate('something', {from: 'js', to: 'en'});
t.fail();
} catch (err) {
t.is(err.code, 400);
t.is(err.message, 'The language \'js\' is not supported');
}
});

test('try to translate to an unsupported language', async t => {
try {
await translate('something', {from: 'en', to: 'js'});
t.fail();
} catch (err) {
t.is(err.code, 400);
t.is(err.message, 'The language \'js\' is not supported');
}
});

0 comments on commit 46f97d3

Please sign in to comment.