Skip to content

Add missing test coverage for Peek methods #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Add missing test coverage for Peek methods #2961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be95fc
Add coverage for peek(runnable, consumer)
bvkatwijk Jan 4, 2025
79fd12e
Update EitherTest.java
bvkatwijk Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/test/java/io/vavr/control/EitherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
import io.vavr.collection.List;
import io.vavr.collection.Seq;
import io.vavr.collection.Vector;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;

import java.util.NoSuchElementException;
Expand Down Expand Up @@ -482,11 +484,35 @@ public void shouldPeekLeftNil() {
@Test
public void shouldPeekLeftForLeft() {
final int[] effect = { 0 };
final Either<Integer, ?> actual = Either.left(1).peekLeft(i -> effect[0] = i);
final Either<Integer, ?> actual = Either.left(1)
.peekLeft(i -> effect[0] = i);
assertThat(actual).isEqualTo(Either.left(1));
assertThat(effect[0]).isEqualTo(1);
}


@Nested
@DisplayName("peek(Runnable, Consumer)")
class PeekRunnableConsumer {
@Test
void shouldConsumePresentValueOnPeekWhenValueIsDefined() {
final int[] actual = new int[] { -1 };
final Either<Integer, ?> testee = Either.left(1)
.peek(i -> actual[0] = 1, i -> actual[0] = 2);
assertThat(testee).isEqualTo(Either.left(1));
assertThat(actual[0]).isEqualTo(1);
}

@Test
void shouldRunRunnableWhenValueIsNotDefined() {
final int[] actual = new int[] { -1 };
final Either<?, Integer> testee = Either.right(1)
.peek(i -> actual[0] = 1, i -> actual[0] = 2);
assertThat(testee).isEqualTo(Either.right(1));
assertThat(actual[0]).isEqualTo(2);
}
}

@Test
public void shouldNotPeekLeftForRight() {
Either.right(1).peekLeft(i -> { throw new IllegalStateException(); });
Expand Down
51 changes: 38 additions & 13 deletions src/test/java/io/vavr/control/OptionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
import io.vavr.*;
import io.vavr.collection.Seq;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;

import java.util.*;
Expand Down Expand Up @@ -509,22 +511,45 @@ public void shouldMakeLeftOnNoneToValidationSupplier() {
assertThat(API.None().toValidation(() -> "bad")).isEqualTo(API.Invalid("bad"));
}

// -- peek
@Nested
class Peek {
@Test
public void shouldConsumePresentValueOnPeekWhenValueIsDefined() {
final int[] actual = new int[] { -1 };
final Option<Integer> testee = Option.of(1).peek(i -> actual[0] = i);
assertThat(actual[0]).isEqualTo(1);
assertThat(testee).isEqualTo(Option.of(1));
}

@Test
public void shouldConsumePresentValueOnPeekWhenValueIsDefined() {
final int[] actual = new int[] { -1 };
final Option<Integer> testee = Option.of(1).peek(i -> actual[0] = i);
assertThat(actual[0]).isEqualTo(1);
assertThat(testee).isEqualTo(Option.of(1));
@Test
public void shouldNotConsumeAnythingOnPeekWhenValueIsNotDefined() {
final int[] actual = new int[] { -1 };
final Option<Integer> testee = Option.<Integer> none().peek(i -> actual[0] = i);
assertThat(actual[0]).isEqualTo(-1);
assertThat(testee).isEqualTo(Option.none());
}
}

@Test
public void shouldNotConsumeAnythingOnPeekWhenValueIsNotDefined() {
final int[] actual = new int[] { -1 };
final Option<Integer> testee = Option.<Integer> none().peek(i -> actual[0] = i);
assertThat(actual[0]).isEqualTo(-1);
assertThat(testee).isEqualTo(Option.none());
@Nested
@DisplayName("peek(Runnable, Consumer)")
class PeekRunnableConsumer {
@Test
void shouldConsumePresentValueOnPeekWhenValueIsDefined() {
final int[] actual = new int[] { -1 };
final Option<Integer> testee = Option.of(1)
.peek(() -> actual[0] = -2, i -> actual[0] = i);
assertThat(actual[0]).isEqualTo(1);
assertThat(testee).isEqualTo(Option.of(1));
}

@Test
void shouldRunRunnableWhenValueIsNotDefined() {
final int[] actual = new int[] { -1 };
final Option<Integer> testee = Option.<Integer> none()
.peek(() -> actual[0] = -2, i -> actual[0] = i);
assertThat(actual[0]).isEqualTo(-2);
assertThat(testee).isEqualTo(Option.none());
}
}

// -- transform
Expand Down
Loading