Upgrade to JUnit 5

[reneleonhardt]

Internal

• Upgrade to JUnit 5

[reneleonhardt]

Notes

• Please squash the commits upon merging, I tried to separate a few fixes
• I added Java 21 to the matrix, I thought I already did that in my update PR... 🤷

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (e43e44b) to head (c83dd29).
Report is 50 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2804      +/-   ##
============================================
- Coverage     92.74%   92.74%   -0.01%     
- Complexity     5247     5256       +9     
============================================
  Files            89       89              
  Lines         12538    12535       -3     
  Branches       1604     1595       -9     
============================================
- Hits          11628    11625       -3     
- Misses          721      724       +3     
+ Partials        189      186       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pivovarit]

Looks good, thanks!

I have one question. I tried running tests on master and your branch, and there are more tests running on yours. Do you have any idea why is that?

master:

yours:

That's probably a good thing, but I'm still wondering what's the cause

[pivovarit]

@reneleonhardt I'd love to merge this one - do you have any clue why this happens?

#2804 (comment)

[reneleonhardt]

JUnit 4 and 5 are totally different, look at the XML report, the test names are different as is the structure (i.e. nested classes).
It would be extremely hard to match 33,000 tests 1:1, I tried 😅
My recommendation would be to enable coverage, then you would have just 2 numbers to compare.
Extracting 2 file lists from JaCoCo reports would be much easier to diff.

[pivovarit]

Amazing work, thanks :)